Modularize Aws::Record #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mullermp
commented
Oct 24, 2024
mullermp
commented
- Checks for Aws::Record before adding things
- Fixes the tests (were previously not running)
- General code cleanup
- README and usage improvements
alextwoods
reviewed
Oct 29, 2024
alextwoods
reviewed
Oct 29, 2024
|
|
||
| module AwsRecord | ||
| module Generators | ||
| class ModelGenerator < Base | ||
| # Generates an Aws::Record model and table configuration. | ||
| class ModelGenerator < Rails::Generators::NamedBase |
There was a problem hiding this comment.
I think I'm still missing something - where does this get required from?
There was a problem hiding this comment.
It's loaded automatically because of its subclass. Just like the session store generators.
alextwoods
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.